fix: correct minimap bucket category resolution#726
Merged
lcottercertinia merged 1 commit intocertinia:mainfrom Feb 12, 2026
Merged
Conversation
lcottercertinia
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Fixes incorrect category resolution in minimap density buckets by reverting a binary search optimization that caused a performance regression.
The minimap was using binary search to find frames per bucket on-demand, but this approach was slower (~90ms) than the original single-pass implementation (~10-20ms). This PR reverts to collecting frames during iteration for correct and fast category resolution.
🛠️ Changes made
framesPerBucketarray for skyline algorithmgetFramesInRange()binary search helper🧩 Type of change (check all applicable)
🔗 Related Issues
N/A - Performance regression from recent optimization
✅ Tests added?
📚 Docs updated?
Anything else we need to know?
Performance measurements:
The binary search optimization attempted to avoid storing frame references, but the repeated search overhead outweighed any memory benefits.